Remove umpyre package accidentally merged into odbcdol (aa5f68e) - #1
Merged
Merged
Conversation
Merge aa5f68e ("Merge copilot/repair-ci-tests from umpyre") pulled an entire unrelated umpyre project into odbcdol's master: the umpyre/ package, its tests under a root tests/ dir, planning docs (PHASE_*/IMPLEMENTATION_*/etc.), a track-metrics action, an umpyre-config.yml, a stray metrics json, and umpyre's CHANGELOG. This removes all of it. odbcdol's own package (odbcdol/) is untouched; the umpyre work is preserved in git history and in the separate i2mint/umpyre repo. Also drops the now-obsolete legacy setup.cfg and the pyproject.toml.migrated artifact (pyproject.toml is the single source of truth).
…stpaths
- license table [project.license]{text=Apache-2.0} -> SPDX string license = "Apache-2.0"
- add trove classifiers + keywords (odbc/pyodbc/sql-server/dol/...)
- drop stray pandas dependency (was added only for the removed umpyre tests;
odbcdol itself does not use pandas)
- testpaths ["tests"] (the removed umpyre root dir) -> ["odbcdol"] so pytest +
--doctest-modules collect odbcdol's own tests and module doctests
- skip-guard the SQLServerPersister smoke test so it skips (instead of erroring)
when no live SQL Server is reachable (CI / dev without a database)
- add .editorconfig (wads template)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove umpyre package accidentally merged into odbcdol
What happened
Merge
aa5f68e— "Merge copilot/repair-ci-tests from umpyre: update CI workflow and add umpyre package" (Dec 2, 2025) — pulled an entire unrelatedumpyreproject into odbcdol'smaster. A Copilot branch that belonged ini2mint/umpyrewas merged here by mistake. It added:umpyre/— the whole umpyre package (collectors, storage, cli, schema, config…)tests/dir containing umpyre's tests (test_umpyre_collector.py,test_config.py, …) that importumpyreandyamlPHASE_2_PLAN.md,PHASE_3_PLAN.md,IMPLEMENTATION_*.md,QUICK_START.md,STORAGE_STRUCTURE.md,TESTING_GUIDE.md,TEST_RESULTS.md,FAILURE_PROTECTION.mdactions/track-metrics/,.github/umpyre-config.yml, a stray metricsjson,misc/CHANGELOG.md(umpyre's),test_on_astate.pyThis is why CI has been red: the umpyre tests import
yaml(undeclared), causing 10 collection errors. It also meant odbcdol's own tests were never actually collected (testpathspointed at the umpyre roottests/).What this PR does
odbcdol/is untouched; the umpyre work is preserved in git history (aa5f68e) and lives in the separatei2mint/umpyrerepo — nothing is lost.setup.cfg+pyproject.toml.migrated(pyproject is the SSOT;setup.pywas already removed in4c38fcf).pandasdep (it was only for umpyre's tests — odbcdol doesn't use pandas),testpaths→["odbcdol"]so odbcdol's own tests + module doctests are collected,.editorconfig.SQLServerPersistersmoke test so it skips (instead of erroring) when no live SQL Server is reachable — CI can now go green without a database service.Note
odbcdol's own smoke test needs a live SQL Server (localhost:1433). It's now skip-when-unavailable, matching the DB-connector cohort (arangodol#1 / couchdol#1). A follow-up (service container vs. keep-skipped) can decide whether to exercise it in CI. The local test gate could not be run on the authoring machine (no
unixodbc; CI installs it via[tool.wads.ops.unixodbc]) — CI on this branch is the verification.https://claude.ai/code/session_0178HR9RvUNxZzLNbjHRKSfM