Skip to content

RedisList: other operations on a wrong-type key leak a raw ResponseError; memoryview elements in lists #15

Closed

Description

@thorwhalen

Minor findings of the review of #14, left out of its scope: (1) on a key holding a string/hash, getitem, slices, len, iteration, append, extend, insert, pop raise a raw WRONGTYPE ResponseError while [i]=/del now raise TypeError: make them consistent; clear() deletes a string key unchecked. (2) bytes-like elements of a list (e.g. a memoryview cast to 'I') go through the list codec unnormalised and corrupt the request (redis-py sends len instead of nbytes); normalise bytes-likes in _list_codec as #14 does for top-level values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions