Repository navigation
RedisList: implement insert/del, fix slicing and IndexError; safe list assignment - #11
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Adversarial review (fresh Opus subagent): no correctness/data-loss bugs. 12,000 randomized differential runs against a python list (raw, decode_responses, codec, tiny batch), plus retry/WATCH, 8-thread concurrency and failure-atomicity probes all passed. Minor findings: non-integer index not TypeError and iter_batch_size<=0 looping forever -> fixed in the last commit (38 tests); wrong-type-key message and bytearray storage -> deferred to a new issue. Dependents gate: redisdol has no dependent suites (see PR #9 note). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6, fixes #7.
insert: exact (duplicate-safe) via WATCH/MULTI with a sentinel + LINSERT;list.insertclamping semantics.__delitem__: atomic MULTI of LSET sentinel + LREM;clear()is a single DEL. So pop/remove/reverse/+= now work.slice.indices(l[:], l[1:0], negatives, steps). Out-of-range int get/set/del raise IndexError (soindex()/interminate). Slice assign/delete: NotImplementedError.iter_batch_size(one lrange per batch).store[k] = []raises ValueError before touching the existing value (no more data loss); list replace is atomic (DEL+RPUSH in MULTI); generators accepted; numbers are stored as strings instead of being silently dropped.