Repository navigation
fix: store_from_source builds dol-wrapped classes (#10) - #13
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
#13) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10.
store_from_source(r, RedisStoreWithNumericLists)raisedAttributeError: 'store': it usedobject.__new__and set_source, but adol-wrapped class delegates to an inner instance (.store). Now, for adol.Storesubclass, the wrapped class and the wrapper class are recovered from the closure of dol's generated__init__(recursively for stacked wrappers); the inner is built oversourceand the wrapper's own__init__runs on it, as in the normal constructor. If it can't be determined (not a dol class-wrapper, a subclass overriding__init__,cache_vals...), a clearTypeError. A public attribute from dol would be cleaner: i2mint/dol#131.Adversarial review (Opus): confirmed the wrapper's own
__init__was skipped (aStoresubclass with state,wrap_kvs(wrapper=...)): fixed, with tests. Verified equal to the normal constructor for wrap_kvs, KeyCodecs+filt_iter, cached_keys, Pipe, mk_read_only, add_path_get; unsupported shapes are refused rather than half-built.🤖 Generated with Claude Code