assess: preserve stale new_design_interface branch (2022) - #26
Closed
thorwhalen wants to merge 1 commit into
Closed
thorwhalen wants to merge 1 commit into
thorwhalen wants to merge 1 commit into
Conversation
Member
Author
|
Preserved via this PR's diff; deleting the stale branch ref (see PR body for the assessment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assessment, not a merge request
Preserving a stale (2022-01-25, 3+ years old), never-PR'd, self-labeled "WIP" branch from an external contributor (Andie Phan, analog.com) before deleting the raw ref, per the fleet's stale-branch cleanup convention.
Content: `stream2py/tests/test_design.py` (166 lines) — a `typing.Protocol`-based sketch of
Reader/CursorFuncinterfaces per the linked wiki page (Stream2py design notes). Its own module docstring says "TODO: Separate protocols and reorganize tests as pytests" -- an acknowledged sketch, not a working test suite.Not merging: explicitly WIP by its own commit message and docstring, no assertions to actually run as tests, predates the current pyproject.toml/wads CI tree entirely. Worth a look if/when the Reader-protocol design work in #17 (BufferReader read/range/init-defaults TODOs) picks back up -- same design space -- but not something to land unattended.
Closing this PR immediately after opening it; the commit stays reachable via this PR's diff and merge-base even after the raw branch ref is deleted.
🤖 Generated with Claude Code
https://claude.ai/code/session_011HSBVhDjRU4apSLcRkavv9