Repository navigation
Test: a failed submit keeps the selection - #16
Merged
Merged
Conversation
…ubmit fail with a file selected) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint review of #15 (empty the uploader after a successful submit). The change is sound. An AST comparison shows that 32 of the 34 files are formatting only, and the real change is all in
elements/elements.py.One test didn't test its name.
test_failed_submit_keeps_the_selectionclicked Submit with nothing uploaded, then uploaded a file. So no submit ever failed while a file was selected, and "a failed submit keeps the selection" was never checked. It now uploads a file the function refuses, an empty one, clicks Submit, and asserts the error and the selection both remain. The test app's function treats empty files as no data, which leaves the other tests unchanged.Test-only change. The merge carries
[skip ci], so no release.🤖 Generated with Claude Code