forked from trueagi-io/hyperon-miner
-
Notifications
You must be signed in to change notification settings - Fork 12
Isurp petta porting #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eyobderese
wants to merge
22
commits into
petta-main
Choose a base branch
from
isurp-petta-porting
base: petta-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Isurp petta porting #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat Implement Mock Unification and Update Module Import Syntax
refactor: Implement get-var using pure list recursion (removing superpose/collapse dependency)
Feature: Unification Function for blk-abstractness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across the empirical probability, surprisingness, and truth value estimation code. The changes focus on standardizing utility function names (e.g., replacing
min/maxwithmin-of-two/max-of-two), improving code clarity, updating type signatures, and enhancing test coverage. Additionally, the pull request updates test files to use local utility imports and adds a comprehensive new test suite for the surprisingness module.Utility function standardization and usage updates:
min/maxwithmin-of-two/max-of-two(and correspondingmin-atom/max-atomin some places) throughout the codebase for consistency, including inemp-tv.metta,isurp-old.metta,isurp.metta,TruthValue.metta, andbeta-dist.metta. [1] [2] [3] [4] [5]Empirical probability and surprisingness logic improvements:
Refactored empirical probability and bootstrapping logic in
emp-prob.metta:emp_prob_subsmpandemp_prob_bs.emp-prob-pbsfor better traceability. [1] [2] [3] [4] [5] [6]Changed partitioning logic in surprisingness and truth value estimation:
generet-partition-without-patternwith the more generalpartitionsfunction inisurp.mettaandest-tv.metta. [1] [2]Type signature and documentation clean-up:
emp-prob.metta,isurp.metta, andemp-tv.mettato streamline code and improve readability. [1] [2] [3] [4] [5]Test infrastructure improvements:
petta-test.mettafor the surprisingness module, including extensive commented-out test cases and utility imports for future expansion.test-blk-abstractness.mettato use local utility imports instead of commented-out global imports, improving modularity and maintainability.These changes collectively improve code consistency, maintainability, and testability across the surprisingness and truth value modules.