added an implmentation for II-surprisigness #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tezena
requested changes
Jan 3, 2026
tezena
left a comment
tezena
left a comment
There was a problem hiding this comment.
Hey, I’ve been going over this and had a suggestion. We could modularize both implementations and reuse shared helper functions. It might also be helpful to add some documentation and clean up unnecessary commented-out code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implmentation of II-surprisingness, one that parallels Isurp-old with concrete values for probabilies and no consideration for confidence or uncertaintity as outlined in the OpenCog paper of measuring surprisingness. Added a test file that measures the II-surpisingness of a pattern on a custom KB , that has concepts that have a super and sub concept relationship amongst eachother. Since II-surprisingness is more constraining , only truely surprssingess patterns that can't be extrapolated from their super and sub concept counterparts get a value higher than 0.
In addtion to this , there is also a pln based II-surprsingess implementation that parallels JSD-surprisingess, the component that gets the truth values for the pattern's super and sub counterparts is complete and i added a test for that, waiting for some JSD-surprsingness to be ported to petta for it to be complete.