Conversation
Amxx
left a comment
Amxx
left a comment
There was a problem hiding this comment.
Out of scope - This is not TLS Notary
| values[id].oracleCallID = _oracleCallID; | ||
| values[id].result = result; | ||
| } | ||
| } |
There was a problem hiding this comment.
This makes no sens. The whole purpose of an oracle is to get a unknown result. If the result is stored at keccak256(result) then you have to know the hash to access the value.
The ValueUpdated made sens in the context of the example (pricefeed) where an index can be updated. Are you expecting for values[id].result to be non-null it would have to contain a string which hash is the same as result's ...
| process.stdout.write(`Failled to verify results (${reason})\n`); | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
This file makes sens for the pricefeed, but is completelly useless here. Either update it to you oracle or remove it!
| console.log(certificate) | ||
|
|
||
| }); | ||
|
|
There was a problem hiding this comment.
You didn't get the point of what TLS Notary is ... at all
You are retreiving a certificat and pushing in onchain as a stringified json file. A smart contract cannot process that.
The concept of TLS notary is, given an URL, to:
- Retrieve the file at the URL
- While doing so, audit the ssl channel to provide cryptographic proof the file was retreived by this channel
- Format the proof so that an external auditor can check it
- Upload the file (or hash of file) and the proof
Just providing a certificate achieves nothing
2 participants
Tls Notary