Open
Conversation
Amxx
reviewed
Jan 20, 2020
Contributor
Amxx
left a comment
Amxx
left a comment
There was a problem hiding this comment.
It feels like there are some unnecessary files here. For example, what is the dwolla-car-validator.js doing in this PR?
Amxx
reviewed
Jan 20, 2020
| // create TLS client | ||
| var client = forge.tls.createConnection({ | ||
| server: false, | ||
| caStore: /* Array of PEM-formatted certs or a CA store object */, |
Amxx
reviewed
Jan 20, 2020
| client.handshake(); | ||
|
|
||
| // when encrypted TLS data is received from the server, process it | ||
| client.process(encryptedBytesFromServer); |
Contributor
There was a problem hiding this comment.
where is encryptedBytesFromServer defined ?
Amxx
reviewed
Jan 20, 2020
| // create TLS server | ||
| var server = forge.tls.createConnection({ | ||
| server: true, | ||
| caStore: /* Array of PEM-formatted certs or a CA store object */, |
Amxx
suggested changes
Jan 20, 2020
Contributor
Amxx
left a comment
Amxx
left a comment
There was a problem hiding this comment.
You are using provable and not iExec. Not sure if you are a trool or just hoping we would not noticed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.