Repository navigation
fix(release): verify every artifact checksum - #28
Merged
Merged
Conversation
Signed-off-by: iHow1 <zyhzai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checksums.txtpath resolve from the Release workflow working directorysha256sum --ignore-missing, so a missing tarball or evidence manifest fails the publish gateRoot cause
release-evidence/checksums.txtpreviously named the tarball and manifest without theirrelease-evidence/prefix, while the workflow ransha256sumfrom the repository root with--ignore-missing. The command could therefore skip the two artifacts it was meant to protect and still succeed after checking only root-level legal files.Verification
checksum target exists from the release workflow cwd: ihow-memory-0.1.0.tgznode --test tests/release-evidence.test.mjs— 2/2 passsha256sum --check /tmp/ihow-release-evidence-green/checksums.txtfrom repository root — 6/6 passnpm run typecheck— passgit diff --check— passRelease boundary
The previous
mainobjecta088dc83f3d5c2c5068fb46fe640078e88d444dcwas invalidated as a release candidate and its in-progress CI run was cancelled. No tag or npm publication occurred. A new immutable RC and full gate are required after this repair merges.