feat: add compatibility with django-allauth v65.4#681
Conversation
|
Hi @iMerica, |
|
@iMerica Can you please take a look at this PR so I can stop getting warnings? Thanks! In the meantime, I added the following to my settings to suppress this. import warnings warnings.filterwarnings( |
|
Trying to use this with django-allauth 65.9 I get this error while running tests |
|
This PR doesn't appear to provide a fixed solution. No updates were made to the registration/serializers.py file which is still generating these deprecated settings warnings: dj_rest_auth/registration/serializers.py:228: UserWarning: app_settings.USERNAME_REQUIRED is deprecated, use: app_settings.SIGNUP_FIELDS['username']['required'] dj_rest_auth/registration/serializers.py:230: UserWarning: app_settings.EMAIL_REQUIRED is deprecated, use: app_settings.SIGNUP_FIELDS['email']['required'] dj_rest_auth/registration/serializers.py:288: UserWarning: app_settings.EMAIL_REQUIRED is deprecated, use: app_settings.SIGNUP_FIELDS['email']['required'] |
These are tracked in a separate issue and pull request:
They were introduced in a different version of django-allauth (65.5), after this fix was submitted. This fix only handles incompatibilities for v65.4 |
LOGIN_METHODSwhen availableAUTHENTICATION_METHOD. Should keepdj-rest-authworking with older allauth versionsdj-rest-authwants to drop support fordjango-allauth < 65.4:AUTHENTICATION_METHODFix #679