feat: Introduce use_httponly_jwt_cookie method#723
Open
AbhijithKonnayil wants to merge 1 commit into
Open
Conversation
…Only cookie setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overrideable
use_httponly_jwt_cookie()hook toLoginViewfixes #722
Summary
This PR introduces a small, backward-compatible extension point to
LoginViewthat allows projects to decide per request whether JWT cookies should be marked asHttpOnly.Instead of relying solely on the static
JWT_AUTH_HTTPONLYsetting, this change adds an instance method that can be overridden via subclassing, following standard Django REST Framework extension patterns.