feat(conversation): add runtime thinking mode selector - #3597
Draft
GodfatherPacino wants to merge 1 commit into
Draft
feat(conversation): add runtime thinking mode selector#3597GodfatherPacino wants to merge 1 commit into
GodfatherPacino wants to merge 1 commit into
Conversation
12 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a runtime thinking-mode selector to the main conversation composer.
thought_level,reasoning_effort, andthinkingoption IDs so Claude Code, OpenCode, and other ACP-compatible CLIs work through their advertised capabilities.Related Issues
No linked issue.
Type of Change
feat: New featurefix: Bug fixperf: Performance improvementrefactor: Code change that neither fixes a bug nor adds a featuredocs: Documentation onlystyle: Formatting onlytest: Tests onlychore: Maintenanceci: CI changesbuild: Build system changesAtomic Change Check
Local Checks
bun run lint/ repository lint gatejust pushRuntime Verification
The packaged arm64 app and embedded backend start successfully, expose the GLM-5.2 selector, and preserve Enabled/Disabled runtime state. A real request against the earlier package revealed that Anthropic-compatible requests omitted the explicit disabled block, so GLM-5.2 continued thinking despite the UI state. That backend defect is fixed by iOfficeAI/aionrs#228 and wired through iOfficeAI/AionCore#628.
The corrected Apple Silicon package passed:
/healthreturned200with version0.1.47The exact Anthropic JSON projection is covered in the Aionrs regression tests. A final external model call is intentionally left to installation-time manual verification so this PR does not use contributor provider credentials implicitly.
Screenshots
Not included. The behavior is covered by focused component tests and packaged-app verification.
Additional Context
The direct Aionrs GLM-5.2 path depends on iOfficeAI/AionCore#628, which in turn currently depends on iOfficeAI/aionrs#228. Third-party ACP integrations are capability-driven and do not hard-code Claude Code or OpenCode behavior.
Self-review