-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(agent): show backend-selected thought level #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itsklimov
wants to merge
2
commits into
iOfficeAI:main
Choose a base branch
from
itsklimov:feat/thought-level-indication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a backend intentionally clears the only exposed config option—or clears every option at once—its snapshot contains only null
current_valuefields. This branch classifies that authoritative update as informationless and restores every still-selectable previous value, leaving the selector showing stale model or thought-level state. A non-null sibling is not a reliable indicator of whether nulls are authoritative; preservation needs to distinguish omitted/partial data from explicit nulls rather than treating every all-null snapshot as empty information.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an intentional anti-flicker tradeoff, and the distinction you're describing isn't representable at the current DTO level.
mergeSnapshotPreservingKnownCurrentsonly preserves previous currents for a frame where every option'scurrent_valueis null. Telling an authoritative all-null snapshot (a backend deliberately clearing every exposed option) apart from an informationless one (an early catalog push before currents land, or an older Core that never stamps currents) requires signaling omitted vs explicit null — butAcpConfigOptionDtocarriescurrent_value: nullas the single representation for both cases. There is no field today that marks a null as authoritative.Given that, preferring preservation for all-null frames is the safer default: it avoids the far more common flash-to-Model-only regression, while any frame carrying at least one non-null current stays authoritative — so the Core's reject re-push still wipes a refused level (the corrected frame keeps the model current, so its effort null passes through). The deliberate clear-everything-at-once case needs a DTO change to distinguish explicit nulls, which is out of scope for this PR. Leaving this thread open to track that as a follow-up rather than expanding scope here.