fix(conversation): always send type and extra in create body (aioncore v0.1.72 compat) - #4245
Open
shoppingarena wants to merge 2 commits into
Open
fix(conversation): always send type and extra in create body (aioncore v0.1.72 compat)#4245shoppingarena wants to merge 2 commits into
shoppingarena wants to merge 2 commits into
Conversation
aioncore v0.1.72 rejects POST /api/conversations bodies that lack the
top-level type or extra field with 'Invalid JSON request body'. The body
builder dropped type whenever an assistant was selected and dropped an
empty extra, so every first submit from the home screen failed with 400.
Always pass type through, default extra to {}, and set the engine type
('aionrs' | 'acp') at both useGuidSend call sites.
Update the four assertions that encoded the old contract (type stripped
when an assistant identity is present) to expect the engine type
('aionrs' | 'acp') to be passed through, matching the aioncore v0.1.72
requirement fixed in the previous commit.
Author
|
Updated the 4 unit-test assertions that encoded the old contract ( For the maintainers: on the v2.1.61 + aioncore v0.1.72 combo this is reproducible live — first submit from the home screen with any assistant selected returns |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On aioncore v0.1.72, every first submit from the home screen fails with
400 Invalid JSON request bodywhen a conversation is created with an assistant selected.Root cause
The backend now requires the top-level
typeandextrafields inPOST /api/conversations. However:buildCreateConversationBody()setstype: undefinedwhenever an assistant is present (JSON.stringify then drops the key), and dropsextrawhen it is not setuseGuidSendcall sites never passtypeResulting body
{"assistant":{...}}(notype, noextra) → 400.Verified against a live v0.1.72 backend:
{"assistant":{"id":X}}→ 400{"assistant":{"id":X},"type":"aionrs","extra":{}}→ 201Fix
typethrough in the body builder and defaultextrato{}'aionrs' | 'acp') at bothuseGuidSendcall sitesVerified end-to-end after rebuild: first submit with an assistant creates the conversation successfully.