fix: reject negative --index in ExcelHandler.Add and PowerPointHandler.Add - #225
Open
Marnie0415 wants to merge 1 commit into
Open
fix: reject negative --index in ExcelHandler.Add and PowerPointHandler.Add#225Marnie0415 wants to merge 1 commit into
Marnie0415 wants to merge 1 commit into
Conversation
…r.Add WordHandler.Add already rejects negative --index values (line 49-54) with a clean error message. ExcelHandler.Add and PowerPointHandler.Add lack this guard — a negative index propagates to collection indexing and surfaces as a raw ArgumentOutOfRangeException. Add the same early validation so all three handlers behave consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add negative
--indexvalidation toExcelHandler.AddandPowerPointHandler.Add, matching the existing guard inWordHandler.Add(line 49-54).Problem
WordHandler.Addrejects negative--indexvalues with a clean"--index must be non-negative."error.ExcelHandler.AddandPowerPointHandler.Addlack this guard — a negative index propagates into collection indexing and surfaces as a raw .NETArgumentOutOfRangeException.Fix
Add the same early validation check at the top of each handler's
Addmethod, before the index is used for any collection operation.Affected paths
This guard covers all three entry points that call
handler.Add:CommandBuilder.Add.csResidentServer.ExecuteAddCommandBuilder.ExecuteBatchItemVerification
Testing
ExecuteBatchItem→handler.Add)Breaking Changes
None. Only invalid inputs (negative
--index) now get a clean error instead of undefined behavior. Valid inputs are unaffected.Notes
WordHandler.Add.csline 49-54