Skip to content

fix: Rotated text overriding custom row heights #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Inference1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Rotated text overriding custom row heights #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ed6d42
Fix rotated text overriding custom row heights
Inference1 Jul 21, 2026
dbd253c
Merge branch 'main' into fix/249-custom-height-rotation
Inference1 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/officecli/Handlers/Excel/ExcelHandler.HtmlPreview.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ private void RenderSheetTable(StringBuilder sb, string sheetName, WorksheetPart

// Row height and hidden row lookup
var rowHeights = new Dictionary<int, double>();
var customHeightRows = new HashSet<int>();
var hiddenRows = new HashSet<int>();
var customHeightRows = new HashSet<int>();
foreach (var row in rows)
Expand All @@ -511,12 +512,12 @@ private void RenderSheetTable(StringBuilder sb, string sheetName, WorksheetPart
hiddenRows.Add(rowIdx);
}

// Rotated-text rows auto-grow in real Excel so the vertical string is
// visible. The HTML <td> only carries transform:rotate, which keeps the
// glyph box at its un-rotated width — the row stays at default height and
// clips. Bump the row's min-height to the rotated text extent (approx
// text-length × font-size for ~90°), consistent with the spill/width
// estimation heuristics elsewhere in this renderer.
// Rotated-text rows with automatic height grow in real Excel so the
// vertical string is visible. The HTML <td> only carries transform:rotate,
// which keeps the glyph box at its un-rotated width — the row stays at
// default height and clips. Bump the row's min-height to the rotated text
// extent (approx text-length × font-size for ~90°), but never override an
// OOXML customHeight row: that height is an explicit user constraint.
foreach (var ((r, _), cell) in cellMap)
{
// An explicit customHeight wins over the rotated-text auto-grow —
Expand Down