Skip to content

fix(xlsx): external-workbook references fall back to their cached value #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiaZhengOng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(xlsx): external-workbook references fall back to their cached value #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/officecli/Core/Formula/FormulaEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,6 +1194,10 @@ private void RestoreBindings(Dictionary<string, FormulaResult> snapshot)

// ==================== Cell & Range Resolution ====================

// External-workbook reference marker in a stored formula (the "[1]" in
// "[1]Sheet!A1"); such refs can't be resolved without the linked file.
private static readonly Regex ExternalRefRe = new(@"\[\d+\]", RegexOptions.Compiled);

internal FormulaResult? ResolveCellResult(string cellRef)
{
cellRef = StripDollar(cellRef).ToUpperInvariant();
Expand Down Expand Up @@ -1250,7 +1254,12 @@ private void RestoreBindings(Dictionary<string, FormulaResult> snapshot)
{
var circularBefore = _session.CircularHits;
var evaluated = EvaluateFormula(ModernFunctionQualifier.Unqualify(cell.CellFormula.Text));
if (evaluated != null)
// An external-workbook reference (=[1]Sheet!A1) can't be resolved without
// the linked file and surfaces as #REF!. Excel keeps the last cached <v>
// for such cells, so fall through to it rather than poisoning every
// dependent total with #REF!. Genuine errors (no external link) still propagate.
if (evaluated != null
&& !(evaluated.IsError && ExternalRefRe.IsMatch(cell.CellFormula.Text)))
{
// Memoize only clean results: no live bindings (see lookup
// guard above) and no circular fallback during this
Expand Down