fix(xlsx): make import mark document modified to save xlsx properly - #280
Open
asomethings wants to merge 1 commit into
Open
fix(xlsx): make import mark document modified to save xlsx properly#280asomethings wants to merge 1 commit into
asomethings wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importchanges cells in memory, but it never setsModified = true.In v1.0.143 (cd4befc)
Dispose()learned to throw away all in-memory changes whenModifiedis false. Soofficecli importprints a success message likeImported 3 rows x 2 cols, but nothing is saved to the file. The same bug was already fixed for Move/Swap/CopyFrom in c84340d. ButImportwas missed.Fix: set
Modified = trueright beforeSaveWorksheet(worksheet), soDispose()saves the imported cells. An empty import returns before this line, so it stays a no-op.Validation (before → after):
/Sheet1/A1is(empty)✗ — nothing on disk/Sheet1/A1 (cell) "name" type=String✓ and/Sheet1/B3 (cell) "20" type=Number✓Also checked the batch path — an
importitem with nosetafter it, which was broken the same way: