Repository navigation
fix: preserve confirmed readings and handle shifted Korean vowels - #15
Merged
helloiamnotth3devnicetomeetyou merged 1 commit intoOct 22, 2026
Merged
Conversation
Keep clean completed previews across confirmation instead of silently accepting a different final language. Retain the existing finishing rules for lone jamo, unfinished romaji and digit boundaries. Show accepted Korean endings on known English stems before confirmation so mixed input remains visible and existing sentence accuracy is preserved. Allow a shifted vowel after a doubled consonant in a lowercase key stream to use ordinary language scores. Preserve raw key case, capitalized English, uppercase abbreviations, explicit cycling and learned choices. Add real-model, session and C FFI regressions, including surrounding text, UTF-16 caret positions, Japanese candidates and synthetic shape learning. The sole golden behavior change keeps the visible wo on Tab rather than replacing it with Korean. Prepare patch version 0.10.9 without publishing. Fixes #11 Fixes #12 Signed-off-by: notth3dev <160973721+noth3dev@users.noreply.github.com>
helloiamnotth3devnicetomeetyou
deleted the
fix/confirmation-shift-overlap
branch
October 22, 2026 22:51
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11 and #12. Confirmation now preserves clean, completed readings, including the reported
연습햇and Japanese preview cases. Completed Korean endings on known English stems appear before confirmation, while existing finishing rules for lone jamo, unfinished romaji, digits, and Japanese candidates remain intact.Shift overlap in
akfgkfRKnow uses normal language scoring and yields말할까. Raw key case, English capitalization, uppercase abbreviations, and explicit language cycling are preserved. Ordinary typing retains its existing fast path.Prepares 0.10.9 and matching English/Korean changelogs; no release is published.
Validation
cargo test --workspace --all-features, formatting, default/all-feature Clippy, and changelog validation passed locally.woon Tab instead of replacing it with재.