Skip to content

Consider query string field for internal redirects#38

Open
annaf-dev wants to merge 4 commits intoiamandycohen:masterfrom
webit-de:20171027_issue27_consider-query-string-internal-redirect
Open

Consider query string field for internal redirects#38
annaf-dev wants to merge 4 commits intoiamandycohen:masterfrom
webit-de:20171027_issue27_consider-query-string-internal-redirect

Conversation

@annaf-dev
Copy link
Copy Markdown

Please have a look, if this fits your code structure.
In my local Sitecore instance it works as expected.

See issue #27 for more information.

@iamandycohen
Copy link
Copy Markdown
Owner

Hello Anna. I am totally open to merging / accepting this pull request. Can you please provide a reason why this is necessary? I am totally open to this, just curious.

Thank you,

Andy

@annaf-dev
Copy link
Copy Markdown
Author

Hello Andy,
we have the case that we want to redirect a shortlink like www.domain.com/shortlink to an internal Sitecore page with a query string (which will be handled by a controller action) like www.domain.com/path/to/sitecore/page?query=string.
I use a Simple Redirect for this case. At the "Target" field I insert an internal link and there is a field "Query string" which will be appended to the internal link. Normally. But this field was not considered by your plugin so far. That's why I added it.
I hope this makes it clear. :)
Anna

@apoetzsch apoetzsch deleted the 20171027_issue27_consider-query-string-internal-redirect branch March 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants