feat(logcat): link severity highlights to Diagnostic groups#4
Open
gvanderclay wants to merge 1 commit intoiamironz:mainfrom
Open
feat(logcat): link severity highlights to Diagnostic groups#4gvanderclay wants to merge 1 commit intoiamironz:mainfrom
gvanderclay wants to merge 1 commit intoiamironz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Logcat already has the same basic severity shape as diagnostics: error, warn, info, debug. The plugin was coloring those with hardcoded named colors (
Red,Yellow,Blue,Green), which can look off depending on the user's colorscheme.This PR links the default logcat severity groups to Neovim's diagnostic groups:
AndroidLogcatError->DiagnosticErrorAndroidLogcatWarn->DiagnosticWarnAndroidLogcatInfo->DiagnosticInfoAndroidLogcatDebug->DiagnosticHintThese are default links, so user-defined
AndroidLogcat*highlights are left alone.What changed
Logcat severity colors now come from the active colorscheme's diagnostic palette instead of fixed named colors. Users who want their own logcat colors can still set the
AndroidLogcat*groups directly.Testing
./scripts/run-tests.sh tests.android.logcat.highlight_test./scripts/run-tests.sh:AndroidLogcatand adb-emitted E/W/I/D log lines