Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,18 @@ Per-release NetBox / Python compatibility lives in

## [Unreleased]

## [0.3.8] — 2026-05-19

### Fixed

- **"Trace this core" button no longer appears twice on the Strand
detail page.** v0.3.7 wired the `plugin_right_page` slot into
`strand.html`, which made the `StrandTraceButton`
`PluginTemplateExtension` fire — but the template also kept the
pre-v0.3.1 inline `{% include 'netbox_osp/inc/trace_button.html' %}`
workaround, so the button rendered twice. Removed the inline
include; the extension is now the single source of truth.

## [0.3.7] — 2026-05-19

Three audit fixes bundled together.
Expand Down Expand Up @@ -426,7 +438,8 @@ GPS markers.

- PyPI name-reservation placeholder. Not functional.

[Unreleased]: https://github.com/iamjohnnymac/netbox-osp/compare/v0.3.7...HEAD
[Unreleased]: https://github.com/iamjohnnymac/netbox-osp/compare/v0.3.8...HEAD
[0.3.8]: https://github.com/iamjohnnymac/netbox-osp/releases/tag/v0.3.8
[0.3.7]: https://github.com/iamjohnnymac/netbox-osp/releases/tag/v0.3.7
[0.3.5]: https://github.com/iamjohnnymac/netbox-osp/releases/tag/v0.3.5
[0.3.4]: https://github.com/iamjohnnymac/netbox-osp/releases/tag/v0.3.4
Expand Down
2 changes: 1 addition & 1 deletion netbox_osp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class NetBoxOspConfig(PluginConfig):
name = "netbox_osp"
verbose_name = "NetBox OSP"
description = "Outside-plant fibre management — cables, splice closures, fibre links with loss budgets, and an offline-capable Leaflet plant map."
version = "0.3.7"
version = "0.3.8"
author = "John McKean"
author_email = "33052970+iamjohnnymac@users.noreply.github.com"
base_url = "osp"
Expand Down
6 changes: 3 additions & 3 deletions netbox_osp/template_content.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ def right_page(self):
class StrandTraceButton(_TraceButtonMixin, PluginTemplateExtension):
"""Inject the trace button onto netbox-osp Strand detail pages.

Some installs disable template extensions on plugin pages — for
those, the strand.html template embeds the button directly via
{% include %}. This extension covers the standard case.
Since v0.3.1 wired plugin_right_page into strand.html this extension
is the only path; the pre-v0.3.1 inline {% include %} workaround was
removed in v0.3.8 to avoid drawing the button twice.
"""
models = ["netbox_osp.strand"]
_trace_url_view_name = "plugins:netbox_osp:strand_trace"
Expand Down
9 changes: 7 additions & 2 deletions netbox_osp/templates/netbox_osp/strand.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@ <h5 class="card-header">Strand</h5>
<tr><th>Loss (dB)</th><td>{{ object.loss_db|floatformat:3 }}</td></tr>
</table>
</div>
{# PR E — visual core tracer entry point #}
{% include 'netbox_osp/inc/trace_button.html' %}
{% comment %}
The "Trace this core" button is rendered via the
StrandTraceButton PluginTemplateExtension into the
plugin_right_page slot below. The pre-v0.3.1 inline
include was removed in v0.3.8 to avoid drawing the button
twice once the plugin slots were wired.
{% endcomment %}
{% plugin_left_page object %}
</div>
<div class="col col-md-6">
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "netbox-osp"
version = "0.3.7"
version = "0.3.8"
description = "Outside-plant fibre management for NetBox — cables, splice closures, fibre links with loss budgets, and an offline-capable Leaflet plant map."
authors = [{ name = "John McKean", email = "33052970+iamjohnnymac@users.noreply.github.com" }]
maintainers = [{ name = "John McKean", email = "33052970+iamjohnnymac@users.noreply.github.com" }]
Expand Down
Loading