Skip to content

Fix/fix the patch to update the status#163

Merged
Suraiyya-786 merged 5 commits into
iamtalib13:version-15from
Suraiyya-786:fix/fix_the_patch_to_update_the_status
May 26, 2026
Merged

Fix/fix the patch to update the status#163
Suraiyya-786 merged 5 commits into
iamtalib13:version-15from
Suraiyya-786:fix/fix_the_patch_to_update_the_status

Conversation

@Suraiyya-786

Copy link
Copy Markdown
Collaborator
  • Exact Status Matching: Replaced loose in operator with strict == to prevent overlapping roles (e.g., HR vs CHRO).
    • Robust Row Identification: Improved find_matching_row to prioritize stage name and level over User ID for better reliability.
    • Safe Syncing: Updated sync_old_to_new to only sync 'Responded' status if the response box actually contains text.
    • No-Overwrite Protection: Updated sync_new_to_old to only update legacy fields if they are empty, preventing data corruption.
    • Permissive Submission: Modified submit_response to accept submissions for both 'Pending' and 'No Response' statuses.
  • Child Table Respondent Check: Refactored button visibility to check the audit_stages child table instead of old hardcoded fields.
    • Post-TAT Submissions: Enabled the 'Submit Response' button even when the status is 'No Response'.
    • Removed Workflow Blocks: Deleted restrictions for 'Audit Report Compliance' and mandatory BM responses for subsequent stages.
    • Smart Action Banner: Implemented a centered, indigo-colored blinking bar at the top to guide active respondents.
    • Tracker Load Fix: Added a 600ms rendering delay to ensure the interactive tracker is visible immediately upon form load.
    • Syntax Correction: Fixed block closures and braces that were causing the form to appear blank.

@Suraiyya-786 Suraiyya-786 merged commit 9889f32 into iamtalib13:version-15 May 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant