Fix/fix the patch to update the status#163
Merged
Suraiyya-786 merged 5 commits intoMay 26, 2026
Merged
Conversation
Suraiyya-786
commented
May 26, 2026
Collaborator
- Exact Status Matching: Replaced loose in operator with strict == to prevent overlapping roles (e.g., HR vs CHRO).
- Robust Row Identification: Improved find_matching_row to prioritize stage name and level over User ID for better reliability.
- Safe Syncing: Updated sync_old_to_new to only sync 'Responded' status if the response box actually contains text.
- No-Overwrite Protection: Updated sync_new_to_old to only update legacy fields if they are empty, preventing data corruption.
- Permissive Submission: Modified submit_response to accept submissions for both 'Pending' and 'No Response' statuses.
- Child Table Respondent Check: Refactored button visibility to check the audit_stages child table instead of old hardcoded fields.
- Post-TAT Submissions: Enabled the 'Submit Response' button even when the status is 'No Response'.
- Removed Workflow Blocks: Deleted restrictions for 'Audit Report Compliance' and mandatory BM responses for subsequent stages.
- Smart Action Banner: Implemented a centered, indigo-colored blinking bar at the top to guide active respondents.
- Tracker Load Fix: Added a 600ms rendering delay to ensure the interactive tracker is visible immediately upon form load.
- Syntax Correction: Fixed block closures and braces that were causing the form to appear blank.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.