Skip to content

[patch] Fix typehints for prepareInstallSecrets() #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
durera merged 1 commit into from
Feb 16, 2026
Merged

[patch] Fix typehints for prepareInstallSecrets() #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/mas/devops/tekton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ def prepareAiServicePipelinesNamespace(dynClient: DynamicClient, instanceId: str
logger.info(f"Storage class {storageClass} uses volumeBindingMode={volumeBindingMode}, skipping PVC bind wait")


def prepareInstallSecrets(dynClient: DynamicClient, namespace: str, slsLicenseFile: str = None, additionalConfigs: dict = None, certs: str = None, podTemplates: str = None) -> None:
def prepareInstallSecrets(dynClient: DynamicClient, namespace: str, slsLicenseFile: dict | None = None, additionalConfigs: dict | None = None, certs: dict | None = None, podTemplates: dict | None = None) -> None:
"""
Create or update secrets required for MAS installation pipelines.

Expand All @@ -408,10 +408,10 @@ def prepareInstallSecrets(dynClient: DynamicClient, namespace: str, slsLicenseFi
Parameters:
dynClient (DynamicClient): OpenShift Dynamic Client
namespace (str): The namespace to create secrets in
slsLicenseFile (str, optional): SLS license file content. Defaults to None (empty secret).
slsLicenseFile (dict, optional): SLS license file content. Defaults to None (empty secret).
additionalConfigs (dict, optional): Additional configuration data. Defaults to None (empty secret).
certs (str, optional): Certificate data. Defaults to None (empty secret).
podTemplates (str, optional): Pod template data. Defaults to None (empty secret).
certs (dict, optional): Certificate data. Defaults to None (empty secret).
podTemplates (dict, optional): Pod template data. Defaults to None (empty secret).

Returns:
None
Expand Down