Extend existing moment instance before loading from dependencies#118
Open
Mihailoff wants to merge 2 commits into
Open
Extend existing moment instance before loading from dependencies#118Mihailoff wants to merge 2 commits into
Mihailoff wants to merge 2 commits into
Conversation
In a multi-plugin world `require 'moment'` leads to problems discussed in icambron#102
Mihailoff
changed the title
icambron
reviewed
Jun 29, 2020
|
|
||
| # -- MAKE AVAILABLE | ||
| return module.exports = makeTwix(require 'moment') if hasModule | ||
| return module.exports = makeTwix(if moment then return moment else require 'moment') if hasModule |
Owner
There was a problem hiding this comment.
won't this throw if moment hasn't been defined as a global?
Author
There was a problem hiding this comment.
In plain JS will work, in CoffeeScript honestly, I don't know. Just double-checked, this code passes tests return module.exports = makeTwix(if moment? then moment else require 'moment') if hasModule
Also, it may have adverse effects on existing users, so technically this should be part of a major "potentially breaking" release.
Author
|
@icambron fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a multi-plugin world
require 'moment'leads to problems discussed in #102