Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a restriction on the use of the
fav(favorite count) filter for booru subscriptions, making it only available for Danbooru-based sites. The changes ensure users are notified with a clear message if they attempt to use thefavfilter on unsupported engines, and this logic is both implemented in the code and covered by new tests.Booru filter engine support and user feedback:
supports_fav_counttoBooruEngineType, returning true only for Danbooru engines, to centralize the logic for favorite count support.unsupported_fav_filter_messagehelper, which checks if a user tried to use thefavfilter on a site that does not support it, and returns a user-friendly error message if so. This helper is now called in all relevant booru subscription command handlers before proceeding, ensuring consistent user feedback. [1] [2] [3] [4]Testing:
unsupported_fav_filter_messageto verify that it only returns an error message for unsupported engines and not for Danbooru.Documentation:
Dependency management:
.github/dependabot.ymlto ignore minor and patch updates for all dependencies, reducing noise from Dependabot for small version changes.