Skip to content

Improve booru fav#84

Merged
icceey merged 3 commits intomasterfrom
improve-booru-fav
Apr 26, 2026
Merged

Improve booru fav#84
icceey merged 3 commits intomasterfrom
improve-booru-fav

Conversation

@icceey
Copy link
Copy Markdown
Owner

@icceey icceey commented Apr 26, 2026

This pull request introduces a restriction on the use of the fav (favorite count) filter for booru subscriptions, making it only available for Danbooru-based sites. The changes ensure users are notified with a clear message if they attempt to use the fav filter on unsupported engines, and this logic is both implemented in the code and covered by new tests.

Booru filter engine support and user feedback:

  • Added a new method supports_fav_count to BooruEngineType, returning true only for Danbooru engines, to centralize the logic for favorite count support.
  • Introduced the unsupported_fav_filter_message helper, which checks if a user tried to use the fav filter on a site that does not support it, and returns a user-friendly error message if so. This helper is now called in all relevant booru subscription command handlers before proceeding, ensuring consistent user feedback. [1] [2] [3] [4]

Testing:

  • Added a unit test for unsupported_fav_filter_message to verify that it only returns an error message for unsupported engines and not for Danbooru.

Documentation:

  • No documentation changes were made for this specific feature, but the logic is clearly encapsulated and tested.

Dependency management:

  • Updated .github/dependabot.yml to ignore minor and patch updates for all dependencies, reducing noise from Dependabot for small version changes.

@icceey icceey merged commit 64e0d54 into master Apr 26, 2026
1 check passed
@icceey icceey deleted the improve-booru-fav branch April 26, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant