Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc8a4301bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the handling of interval-based booru subscriptions, particularly standardizing interval key formats, tightening validation, and simplifying related logic. It also enhances the display of booru subscription information and adds/updates tests for new behaviors.
Interval Key Handling and Validation:
Standardized interval representation for booru ranking subscriptions to use a strict canonical key format (e.g.,
"3600s") instead of ISO8601 (e.g.,"PT1H"), affecting both parsing and serialization inBooruTaskKeyand related handler logic. Validation now rejects ambiguous or invalid formats (e.g.,"1h","60m","0s"). [1] [2] [3] [4] [5] [6] [7] [8]Refactored the subscription handler to use the new interval key functions and updated user-facing messages and internal logic to reflect the new format. [1] [2] [3] [4] [5] [6] [7] [8]
Internal Key Parsing and Subscription Logic:
parse_bunsub_internal_keyfunction to distinguish between internal and user-facing subscription keys, improving the ability to handle edge cases and unsubscriptions. [1] [2] [3]Display and Listing Improvements:
Testing Enhancements:
Code Cleanup:
These changes collectively make interval subscription handling more robust, user-friendly, and maintainable.