Skip to content

Await connection callback instead of creating a detached task #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lnagel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Await connection callback instead of creating a detached task #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions proxyprotocol/reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,8 @@ def get_callback(self, callback: _WrappedCallback,
to :func:`asyncio.start_server`.

The returned callback will first read the PROXY protocol header before
starting the provided *callback* as a :class:`~asyncio.Task`. The
*callback* argument is similar to *client_connected_cb* but with an
additional positional argument -- the
calling the provided *callback*. The *callback* argument is similar to
*client_connected_cb* but with an additional positional argument -- the
:class:`~proxyprotocol.sock.SocketInfo` read from the header.

Args:
Expand All @@ -89,4 +88,4 @@ async def _read_then_call(self, callback: _WrappedCallback,
writer.close()
result = ProxyResultUnknown(exc)
sock_info = SocketInfo.get(writer, result, unique_id=uuid4().bytes)
asyncio.create_task(callback(reader, writer, sock_info))
await callback(reader, writer, sock_info)