Fix Generate_results_figures for Model B outputs and overlapping columns - #4
Open
Watcher1223 wants to merge 1 commit into
Open
Conversation
- Find dispatch CSVs in Simulation_Results/<project> or first subfolder that contains all three files (Julia may write nested case dirs). - Validate row counts (8760) and missing files with clear messages. - Map p_G_ht and p_G_Gr_ht from Model A/B plant outputs to display names. - Disambiguate duplicate column names (e.g. q_G_jht) before joining hydro with plant+storage. - Use resample ME instead of deprecated M; trim debug output. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
Generate_results_figures.pyso post-optimization HTML figures build reliably for current HydroBoost CSV layouts (including Model B).Changes
_find_result_dirlocateshydro/plant/storagedispatch CSVs underSimulation_Results/<project>or the first subfolder that contains all three (when Julia writes case-specific subdirs).p_G_htandp_G_Gr_ht(Model A/B naming) to the same display labels asp_HT_ht/p_HG_ht, so revenue columns resolve (Hydropower to Grid, etc.).q_G_jht; merge plant+storage first, rename overlapping columns with a_plantsuffix on the plant side, then join hydro.resample('ME')instead of deprecated'M'; remove noisyprint(df.columns); one-line confirmation of output directory.Testing
python Generate_results_figures.py Model_Blocally against Model B simulation outputs; figures written underSimulation_Results/.../Figures/.Upstream reference: idaholab/HydroBoost.
Made with Cursor