Full ranged ZrCoHx PCT modelling capabilities by Anthony-Bowers08 · Pull Request #420 · idaholab/tmap8

Anthony-Bowers08 · 2026-05-30T17:08:21Z

Ref. #261

Reason

Design

Full range ZrCo PCT modelling capabilities

Impact

Full range ZrCo PCT modelling capabilities

simopier

This is a partial review, not a full detailed one.

Please address these things first.

You are also missing an issue number in your commit history:

##########################################################################
ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
Merge branch 'ZrCoHx_FullRange_PCT_Modelling' of https://github.com/Anthony-Bowers08/TMAP8 into test
Full ranged ZrCoHx PCT modelling capabilities Ref. 261
##########################################################################

simopier · 2026-06-04T20:34:11Z

This PR is still failing due to:

##########################################################################
ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
Merge branch 'ZrCoHx_FullRange_PCT_Modelling' of https://github.com/Anthony-Bowers08/TMAP8 into test
Apply suggestions from code review
Apply suggestion from @simopier
Full ranged ZrCoHx PCT modelling capabilities Ref. 261
##########################################################################

moosebuild · 2026-06-10T21:25:49Z

Job Documentation, step Sync to remote on fcf3ec4 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2026-06-10T23:36:05Z

Job Coverage, step Generate coverage on fcf3ec4 wanted to post the following:

Coverage

	9d9626	#420 fcf3ec
	Total	Total	+/-	New
Rate	90.71%	91.04%	+0.33%	100.00%
Hits	1367	1402	+35	52
Misses	140	138	-2	0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

simopier

Getting closer too! Let me know if you have any questions about these comments and suggestions.

moosebuild · 2026-07-27T19:05:22Z

Job Precheck, step Python: black format on 7628199 wanted to post the following:

Python black formatting

Your code requires style changes.

A patch was generated and copied here.

You can directly apply the patch by running the following at the top level of your repository:

curl -s https://mooseframework.inl.gov/tmap8/docs/PRs/420/black/black.patch | git apply -v

Alternatively, you can run the following at the top level of your repository:

black --config pyproject.toml --workers 1 .

simopier

Quick partial review.

moosebuild · 2026-08-25T19:34:18Z

Job Precheck, step Format Check Clang on 26c4624 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/tmap8/docs/PRs/420/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 121fdc4ef91b7bb6abb4581cf81e17a1a72b66e6

simopier

Things look good overall but tests are failing.

Anthony-Bowers08 · 2026-08-25T21:49:05Z

Strange, they pass on my end. I will re-run tests and compare with the PR. Respectfully, Anthony Bowers Postdoctoral Researcher Idaho National Laboratory Office: 208-533-4078

…

________________________________ From: Pierre-Clement Simon ***@***.***> Sent: Tuesday, August 25, 2026 3:48 PM To: idaholab/tmap8 ***@***.***> Cc: Anthony George Bowers ***@***.***>; State change ***@***.***> Subject: Re: [idaholab/tmap8] Full ranged ZrCoHx PCT modelling capabilities (PR #420) @simopier requested changes on this pull request. Things look good overall but tests are failing. — Reply to this email directly, view it on GitHub<#420?email_source=notifications&email_token=BWATFGIP7FQIHYX4HFYHL7D5LYCSBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBSGQ2TKMZWGIY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-5024553621>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BWATFGOG6RD37GO4UXJFTM35LYCSBAVCNFSNUABFKJSXA33TNF2G64TZHMZTENRYGQYTINJXHNEXG43VMU5TINJVGUYDSNBWGQ22C5QC>. Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/BWATFGIUUT6HFIWFXW7JRI35LYCSBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBSGQ2TKMZWGIY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android<https://github.com/notifications/mobile/android/BWATFGNBEDT6VRCSAYQZU7T5LYCSBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBSGQ2TKMZWGIY2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you modified the open/close state.Message ID: ***@***.***>

simopier

Small change

simopier

You get one csvdiff:

DIFF test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_524K_csv FAILED (CSVDIFF)

In the documentation, MOOSEdocs has changed and now requires input files to be cross-referenced as [!file](/input_name.i). You will need to update these.

simopier

Things look good overall, but you have added a bunch of csv files in the gold folder that are not tested. You should remove them.

…dbility via comments

Co-authored-by: Pierre-Clement Simon <pierreclement.simon@gmail.com>

…re formatting

…HxPCT.md

…ld case files

…as a place holder for development

moosebuild · 2026-08-28T21:38:26Z

Job Build test summary, step Build test summary on b5b0c36 wanted to post the following:

Test summary

Compared against 9d96263 in job civet.inl.gov/job/4115258.

Removed tests

Test	Time (s)	Memory (MB)
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T604_5E4P_csv`	3.67	125.25
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T433_1E4P_csv`	3.64	137.33
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T573_1E4P_csv`	3.63	123.25
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T433_3E4P_csv`	3.54	141.97
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T604_6E3P_csv`	3.52	168.39
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T573_1E3P_csv`	3.47	127.29
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T433_1E2P_csv`	3.07	166.42

Added tests

Test	Time (s)	Memory (MB)
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T604_5E2P_csv`	4.57	141.79
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T524_3E4P_csv`	4.32	126.43
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_604K_csv`	4.31	298.18
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T423_1E4P_csv`	4.16	142.44
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_T524_5E2P_csv`	4.05	144.48
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_524K_csv`	3.92	204.13
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_564K_csv`	3.89	204.49
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_423K_csv`	3.63	170.58
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_584K_csv`	3.42	203.29
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_624K_csv`	2.83	295.90
`test:ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_544K_csv`	2.80	169.79

simopier · 2026-08-31T04:11:57Z

You get this failure in test summary and conda test linux (but not in tests). Maybe relax the rel_tol a bit:

DIFF ZrCo_hydrogen_system.ZrCoHx_PCT_Low_to_High_524K_csv FAILED (CSVDIFF)

simopier self-assigned this Jun 3, 2026

simopier requested changes Jun 3, 2026

View reviewed changes

Anthony-Bowers08 force-pushed the ZrCoHx_FullRange_PCT_Modelling branch from 6e56f25 to f898b6b Compare June 11, 2026 18:36

Anthony-Bowers08 closed this Jun 11, 2026

Anthony-Bowers08 force-pushed the ZrCoHx_FullRange_PCT_Modelling branch from f898b6b to 681717b Compare June 11, 2026 19:23

lin-yang-ly reopened this Jun 11, 2026

Anthony-Bowers08 force-pushed the ZrCoHx_FullRange_PCT_Modelling branch from da77422 to f898b6b Compare June 11, 2026 20:11

lin-yang-ly force-pushed the ZrCoHx_FullRange_PCT_Modelling branch from f898b6b to f1d8f2f Compare June 11, 2026 20:48

lin-yang-ly changed the title ~~Full ranged ZrCoHx PCT modelling capabilities Ref. 261~~ Full ranged ZrCoHx PCT modelling capabilities Jun 11, 2026

simopier requested changes Jun 22, 2026

View reviewed changes

Anthony-Bowers08 force-pushed the ZrCoHx_FullRange_PCT_Modelling branch from 7628199 to 82f2a6a Compare July 27, 2026 22:02

simopier requested changes Aug 4, 2026

View reviewed changes

Comment thread doc/content/source/interfacekernels/ADMatInterfaceReactionZrCoHxPCT.md Outdated

Comment thread doc/content/source/interfacekernels/ADMatInterfaceReactionZrCoHxPCT.md Outdated

Comment thread doc/content/source/interfacekernels/ADMatInterfaceReactionZrCoHxPCT.md Outdated

simopier reviewed Aug 4, 2026

View reviewed changes

Comment thread src/interfacekernels/ADMatInterfaceReactionZrCoHxPCT.C Outdated

simopier requested changes Aug 25, 2026

View reviewed changes

simopier requested changes Aug 27, 2026

View reviewed changes

Comment thread doc/content/source/interfacekernels/ADMatInterfaceReactionZrCoHxPCT.md Outdated

simopier requested changes Aug 27, 2026

View reviewed changes

simopier requested changes Aug 28, 2026

View reviewed changes

lin-yang-ly and others added 7 commits August 28, 2026 15:31

Add full-range ZrCoHx PCT modeling idaholab#260

dc6c317

Updates to ZrCoHx Modelling

23af381

Adding missing PCT files

5a0b53f

Applying suggested code changes, consolidating figures, improving rea…

c54dba9

…dbility via comments

Adding source file formating

45da216

Apply suggestions from code review

e1014d6

Co-authored-by: Pierre-Clement Simon <pierreclement.simon@gmail.com>

Improvements to variable naming, coding logic, and documentation/figu…

8a0feb9

…re formatting

Bowers and others added 10 commits August 28, 2026 15:31

Ran the clang-format for the source file

88558fc

Fixing test cases and improving plotting

fb59f8a

Appling formatting

9633bd1

Update doc/content/source/interfacekernels/ADMatInterfaceReactionZrCo…

22d4dcf

…HxPCT.md

Adding test case

9135dd0

Fixing documentation input file cross referencing

be70333

Improving Test Files

9e49464

Improvments to python script and documentation. Removing uncessary go…

f08f71d

…ld case files

Forgot to remove an uncesessary comment in the python file. Comment w…

a7ae0d4

…as a place holder for development

Didnt realize I needed to reformat for deleting a comment

e5ecb0f

Fixing gold file

fcf3ec4

Anthony-Bowers08 force-pushed the ZrCoHx_FullRange_PCT_Modelling branch from b5b0c36 to fcf3ec4 Compare August 28, 2026 22:26

Uh oh!

Conversation

Anthony-Bowers08 commented May 30, 2026 • edited by lin-yang-ly Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reason

Design

Impact

Uh oh!

simopier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simopier commented Jun 4, 2026

Uh oh!

moosebuild commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moosebuild commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage

Uh oh!

simopier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Jul 27, 2026

Python black formatting

Uh oh!

simopier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Aug 25, 2026

Uh oh!

simopier left a comment

Choose a reason for hiding this comment

Uh oh!

Anthony-Bowers08 commented Aug 25, 2026 via email

Uh oh!

simopier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

simopier left a comment

Choose a reason for hiding this comment

Uh oh!

simopier left a comment

Choose a reason for hiding this comment

Uh oh!

moosebuild commented Aug 28, 2026

Test summary

Removed tests

Added tests

Uh oh!

simopier commented Aug 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Anthony-Bowers08 commented May 30, 2026 •

edited by lin-yang-ly

Loading

moosebuild commented Jun 10, 2026 •

edited

Loading

moosebuild commented Jun 10, 2026 •

edited

Loading