Add Validation Case for Deuterium Retention in Neutron-Irradiated Tungsten: Improving upon TMAP7 - #451
Draft
edbworth wants to merge 12 commits into
Draft
Add Validation Case for Deuterium Retention in Neutron-Irradiated Tungsten: Improving upon TMAP7#451edbworth wants to merge 12 commits into
edbworth wants to merge 12 commits into
Conversation
…to remove source term and instead use initial condition to represent distribution of deuterium due to ion flux.
…ple comparison and animation script improvements (Ref. idaholab#405)
|
Job Precheck, step Python: black format on bffe8b6 wanted to post the following: Python black formattingYour code requires style changes. A patch was generated and copied here. You can directly apply the patch by running the following at the top level of your repository: Alternatively, you can run the following at the top level of your repository: |
Contributor
Author
|
@simopier Please add the necessary labels to this PR: V&V and AI assisted. |
simopier
added
PR: AI assisted
simopier
requested changes
Aug 17, 2026
simopier
left a comment
simopier
left a comment
Collaborator
There was a problem hiding this comment.
Some quick review comments:
- finalize documentation
- add comment at the top of python scripts to explain what they do and how they are used if they are called by another script.
- remove commented out lines in the input file.
- add gold folder with test results
- add validation case to the list in the V&V index page.
- Fix python script failure
…plots, Added parameter file, Added headers to files to indicate their purpose, removed commented out lines from input file, fixed local python black formatting issues, To do: documentation, gold folder, V&V index page
…les to match verification and benchmarking cases. Cleaned up and added description to comparison python file, added gold file with current simulation results, modifying timestepper to keep test shorter while still capturing physics, added CSVDiff and RunApp tests
…omparison script and added digitized data to gold file
|
Job Documentation, step Sync to remote on 97e3fe2 wanted to post the following: View the site here This comment will be updated on new commits. |
…ical temperature regions and regions with flux measured over a certain threshold. This refines the timestep in the critical simulation regions, allowing for the temperature piecewise linear function to have proper experimental curvature and for sharp TDS spectra to be measured properly. Added a timestep tracker to the comparison script. Tests will take too long using this timestepper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"refs #405"