Upgrade HighriseApi to .NET Standard 2.0 - #1
Merged
Conversation
Convert the project from .NET Framework 4.7.2 to .NET Standard 2.0 using the SDK-style project format with PackageReference dependencies. Replace System.Web.HttpUtility with System.Net.WebUtility for URL encoding to remove the System.Web dependency, which is not available on .NET Standard. Remove legacy packages.config, app.config, and AssemblyInfo.cs in favor of SDK-style project metadata and NuGet package management. Co-authored-by: Pascal Knecht <pascalknecht@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (15)
📝 WalkthroughWalkthroughThe library is migrated from a legacy .NET Framework project to SDK-style Changes.NET modernization
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Run dotnet restore and build for the netstandard2.0 library on every push using Ubuntu and .NET 8. Co-authored-by: Pascal Knecht <pascalknecht@users.noreply.github.com>
Delete the legacy example console app, checked-in RestSharp.dll, and Visual Studio cache files. Add .vs/ to .gitignore to prevent re-commit. Co-authored-by: Pascal Knecht <pascalknecht@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the
HighriseApilibrary from .NET Framework 4.7.2 to .NET Standard 2.0 so it can be consumed from .NET Framework, .NET Core, and modern .NET applications.Changes
HighriseApi.csprojto SDK-style format targetingnetstandard2.0packages.configwithPackageReferenceentries for RestSharp dependenciesapp.configbinding redirects (no longer needed with SDK-style projects)System.Web.HttpUtility.UrlEncodewithSystem.Net.WebUtility.UrlEncodeinDictionaryExtensionsto remove theSystem.WebdependencySystem.Text.Jsonpackage referenceAssemblyInfo.csin favor of SDK-generated assembly metadataexample/,lib/, andsrc/.vs/folders from the repository.vs/to.gitignoreVerification
dotnet build -c Releasesucceeds with 0 warnings and 0 errorsSummary by CodeRabbit
New Features
Bug Fixes
Chores