Skip to content

Conversation

@geetha-1z
Copy link
Contributor

@geetha-1z geetha-1z commented Jan 22, 2026

Updating the feature flag check to return false if it's not present
The previous code is failing to check the feature flag and here is the issue
PolypressRegistry.namespace([:polypress, :paper_notices]).feature_enabled?(:upload_paper_notices_to_s3)[10:40 AM]irb(main):003:0> PolypressRegistry.namespace([:polypress, :paper_notices]).feature_enabled?(:upload_paper_notices_to_s3)Traceback (most recent call last):    2: from (irb):2    1: from (irb):3:in rescue in irb_binding'NoMethodError (undefined method arity' for nil:NilClass)

The updated code which is in this PR shows below results in the console

PVT
irb(main):001:0> PolypressRegistry.feature_enabled?(:upload_paper_notices_to_s3)
=> true
PVT-3
irb(main):001:0> PolypressRegistry.feature_enabled?(:upload_paper_notices_to_s3)
=> false

@geetha-1z geetha-1z added bug Something isn't working good first issue Good for newcomers enhancement New feature or request and removed bug Something isn't working good first issue Good for newcomers labels Jan 22, 2026
@saikumar9 saikumar9 enabled auto-merge (squash) January 22, 2026 18:48
@saikumar9 saikumar9 merged commit 378c5bc into trunk Jan 22, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants