update the check of feature flag #171
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the feature flag check to return false if it's not present
The previous code is failing to check the feature flag and here is the issue
PolypressRegistry.namespace([:polypress, :paper_notices]).feature_enabled?(:upload_paper_notices_to_s3)[10:40 AM]irb(main):003:0> PolypressRegistry.namespace([:polypress, :paper_notices]).feature_enabled?(:upload_paper_notices_to_s3)Traceback (most recent call last): 2: from (irb):2 1: from (irb):3:inrescue in irb_binding'NoMethodError (undefined methodarity' for nil:NilClass)The updated code which is in this PR shows below results in the console