update the code to add logger statements and support the test scenari… #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os for previous fix for the featue flag
kristinmerbach
approved these changes
Jan 23, 2026
Contributor
kristinmerbach
left a comment
kristinmerbach
left a comment
There was a problem hiding this comment.
Great work adding so much logging for future debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket :
https://app.clickup.com/t/868gmw6re
I tested the flow from polypress to cartafact in pvt as we have the code deployed now on both the repos and seems like the call is not happening from polypress to cartafact as it's failing user validation. .In the debugging I figured out that we must pass the user as nil to keep it same as upload_document method .
Also we need some logger statements in the code to check what is exactly happening and if there is any issue in any method
The code is working fine from the point where it makes a call from copy service in polypress to cartafact . Confirmed that from calling the command from rails console.
HTTParty.get(fetch_url + "/#{document_hash[:id]}/copy", headers: header)and the document is saved in s3.This PR includes :
Logger statements to check the flow from Polypress to Cartafact
Updated the test cases based upon the previous fix made to check the upload_paper_notices_to_s3 flag enabled .
Pass the user as nil while calling the copy service as we are doing the same in upload method.