Skip to content

Conversation

@bbodine1
Copy link
Contributor

This pull request updates the Angular quoting tool project to improve maintainability, enforce strict versioning, and simplify brand-specific configuration. The most significant changes are the switch to a centralized brand config file for environment-based file replacements, the introduction of strict Node/npm version locking, and the addition of detailed documentation for setup and maintenance.

Brand configuration and file replacement simplification:

  • Replaced multiple asset file swaps in angular.json with a single brand config file swap (brand.config.ts), making it easier to maintain and expand brand-specific settings. File replacements now target only the config file per brand/environment. [1] [2] [3]
  • Added FILE_REPLACEMENTS.md to document the new brand configuration approach, including example configs and build commands.

Toolchain and dependency management:

  • Updated Node.js and npm version pins in .nvmrc, .node-version, and added strict engine enforcement in .npmrc to ensure reproducible builds and installs. [1] [2] [3]
  • Expanded the README with clear instructions for version management, toolchain setup, updating dependencies, and app structure.

Frontend build and linting improvements:

  • Switched Angular build builder to @angular/build:application and updated build options for better compatibility and optimization.
  • Added a project-level ESLint config (.eslintrc.json) with Angular and TypeScript rules for consistent code quality.
  • Added .browserslistrc for browser support targeting the latest Chrome, Firefox, and Safari.

Miscellaneous updates:

  • Updated .gitignore to exclude Angular cache directory.
  • Removed the legacy submodule reference for html-bak.

These changes collectively make the project easier to maintain, ensure consistent builds, and streamline brand-specific customization.

@bbodine1 bbodine1 self-assigned this Aug 27, 2025
…tions. Refactor component templates for improved formatting and structure. Adjust TypeScript configuration for module resolution and include additional schematics for Angular components.
…versions 19.0.1 for @ng-bootstrap/ng-bootstrap and 14.0.0 for @sweetalert2/ngx-sweetalert2, ensuring compatibility with Angular 20.
…mrc, package.json, and README.md. Pin dependencies to exact versions in package.json and package-lock.json for improved stability and reproducibility. Adjust mock server start dates and environment API URL for local development.
…ding. Update angular.json to include new build configurations for different brands, adjust asset paths, and streamline polyfills. Modify header and employer details components to utilize BRAND_CONFIG for logo and template paths, enhancing flexibility. Clean up custom.scss by removing unnecessary max-width setting for larger breakpoints.
…properties for improved theming flexibility. Update client-specific stylesheets for DC, MA, and ME to utilize the new variable structure, ensuring consistent branding across different regions. Clean up variable.scss to import client styles and remove redundant theme color definitions.
…uster EOL, and disable Release file validity checks for successful updates and installations.
@bbodine1 bbodine1 force-pushed the angular-upgrade-08-25 branch from d15bd4c to 466bda2 Compare August 28, 2025 14:24
Copy link

@saipraveen18 saipraveen18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

@kristinmerbach kristinmerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristinmerbach kristinmerbach merged commit a006adf into trunk Sep 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants