-
Notifications
You must be signed in to change notification settings - Fork 0
angular upgrade 08 25 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions. Refactor component templates for improved formatting and structure. Adjust TypeScript configuration for module resolution and include additional schematics for Angular components.
…versions 19.0.1 for @ng-bootstrap/ng-bootstrap and 14.0.0 for @sweetalert2/ngx-sweetalert2, ensuring compatibility with Angular 20.
…mrc, package.json, and README.md. Pin dependencies to exact versions in package.json and package-lock.json for improved stability and reproducibility. Adjust mock server start dates and environment API URL for local development.
…ding. Update angular.json to include new build configurations for different brands, adjust asset paths, and streamline polyfills. Modify header and employer details components to utilize BRAND_CONFIG for logo and template paths, enhancing flexibility. Clean up custom.scss by removing unnecessary max-width setting for larger breakpoints.
…properties for improved theming flexibility. Update client-specific stylesheets for DC, MA, and ME to utilize the new variable structure, ensuring consistent branding across different regions. Clean up variable.scss to import client styles and remove redundant theme color definitions.
…uster EOL, and disable Release file validity checks for successful updates and installations.
d15bd4c to
466bda2
Compare
saipraveen18
approved these changes
Sep 26, 2025
saipraveen18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
kristinmerbach
approved these changes
Sep 26, 2025
kristinmerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Angular quoting tool project to improve maintainability, enforce strict versioning, and simplify brand-specific configuration. The most significant changes are the switch to a centralized brand config file for environment-based file replacements, the introduction of strict Node/npm version locking, and the addition of detailed documentation for setup and maintenance.
Brand configuration and file replacement simplification:
angular.jsonwith a single brand config file swap (brand.config.ts), making it easier to maintain and expand brand-specific settings. File replacements now target only the config file per brand/environment. [1] [2] [3]FILE_REPLACEMENTS.mdto document the new brand configuration approach, including example configs and build commands.Toolchain and dependency management:
.nvmrc,.node-version, and added strict engine enforcement in.npmrcto ensure reproducible builds and installs. [1] [2] [3]Frontend build and linting improvements:
@angular/build:applicationand updated build options for better compatibility and optimization..eslintrc.json) with Angular and TypeScript rules for consistent code quality..browserslistrcfor browser support targeting the latest Chrome, Firefox, and Safari.Miscellaneous updates:
.gitignoreto exclude Angular cache directory.html-bak.These changes collectively make the project easier to maintain, ensure consistent builds, and streamline brand-specific customization.