Conversation
triet228
added this pull request to stack #89
September 16, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focused follow-up to #87. This PR is based on PR #86.
Upstream and downstream operational splits can each satisfy their own row-sum constraints while assigning different power to the same physical edge. CheckEdgePowerConsistency propagates sink demand and compares delivered power on each edge, including upstream edge efficiency. FAST rejects a mismatch with: "Edge power is not consistent. Your power splits are over-constrained."
FAST/+PropulsionPkg/CheckEdgePowerConsistency.m
Lines 37 to 61 in f613377
PropAnalysis evaluates both operational matrices at each mission point and runs the edge check, including downstream windmilling redistribution when applicable.
FAST/+PropulsionPkg/PropAnalysis.m
Lines 133 to 142 in f613377
TestEdgePowerConsistency covers consistent and inconsistent edge flows; it is registered in TestFAST.
FAST/+PropulsionPkg/TestEdgePowerConsistency.m
Line 1 in f613377
FAST/TestFAST.m
Line 34 in f613377
Validation
PropulsionPkg.TestEdgePowerConsistency() and PropulsionPkg.TestEngineMotorRegressions() pass.