Skip to content

fix: handle no nameservers exception #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ideepu merged 1 commit into from
Mar 2, 2026
Merged

fix: handle no nameservers exception #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ def get_domain_policy_record(
res = resolver or dns.resolver.get_default_resolver()
try:
txt_records = res.resolve(qname=name, rdtype=RdataType.TXT, lifetime=timeout)
except (dns.resolver.NoAnswer, dns.resolver.NXDOMAIN, dns.resolver.LifetimeTimeout) as e:
except (
dns.resolver.NoAnswer,
dns.resolver.NXDOMAIN,
dns.resolver.LifetimeTimeout,
dns.resolver.NoNameservers,
) as e:
raise DomainPolicyError('Domain policy record not found') from e
for record in txt_records:
record_text = ''.join(a.decode('utf-8') for a in record.strings)
Expand Down
9 changes: 9 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ def raise_timeout(*_args: object, **_kwargs: object) -> None:
get_domain_policy_record('example.com', 'v=spf1', resolver=dns.resolver.Resolver(), timeout=1)


def test_get_domain_policy_record_no_nameservers(monkeypatch: pytest.MonkeyPatch) -> None:
def raise_no_nameservers(*_args: object, **_kwargs: object) -> None:
raise dns.resolver.NoNameservers()

monkeypatch.setattr(dns.resolver.Resolver, 'resolve', raise_no_nameservers)
with pytest.raises(DomainPolicyError):
get_domain_policy_record('example.com', 'v=spf1', resolver=dns.resolver.Resolver(), timeout=1)


def test_get_domain_policy_record_no_matching_marker() -> None:
mock_record = MagicMock()
mock_record.strings = [b'some-other-txt-record']
Expand Down