Move CheckNan to end of loop on stages in timeIntegrator - #403
Open
nscepi wants to merge 2 commits into
Open
Conversation
CheckNan was previously located after EvolveStage. However, EvolveStage
updates the conservative variables and CheckNan checks the primitive
variables. This reports the detection of a NaN to the next cycle. By
moving CheckNan to the end of the loop on stages in timeIntegrator,
so after the ConsToPrim, this PR ensures that we detect the NaN at
the right cycle.
glesur
self-requested a review
August 31, 2026 10:03
glesur
requested changes
Aug 31, 2026
| if(data.haveFargo) data.fargo->AddVelocity(data.t); | ||
| } | ||
|
|
||
| // Look for Nans every now and then (this actually cost a lot of time on GPUs |
Contributor
There was a problem hiding this comment.
At this point, CheckNan() will be executed once for each integration stage each time we reach the number of cycles requested (so possibly 2 or 3 times). I think checkNan should come at the very end of each integration cycle, not at the end of each stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckNan was previously located after EvolveStage. However, EvolveStage updates the conservative variables and CheckNan checks the primitive variables. This delays the detection of a NaN to the next cycle. By moving CheckNan to the end of the loop on stages in timeIntegrator, so after the ConsToPrim, this PR ensures that we detect the NaN at the cycle where it was created.