fix: route Makefile recipes through Git Bash on Windows - #254
Merged
Conversation
GNU Make for Windows dispatches recipes through cmd.exe and ignores a Makefile SHELL reassignment for that dispatch, so `./mvnw` and `chmod` fail with "'.' não é reconhecido..." when running `make build`/`make seed` from PowerShell or cmd. Invoke bash.exe explicitly per recipe instead, using its standard Git-for-Windows path rather than relying on `bash` resolving on PATH, since machines with WSL installed can have `bash` resolve to the WSL launcher stub ahead of Git Bash. Verified `make build` completes with BUILD SUCCESS from PowerShell.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make build/make seedfailed on Windows PowerShell/cmd with'.' não é reconhecido como um comando interno...because GNU Make for Windows dispatches recipes throughcmd.exe, which doesn't understand./mvnw, and ignores a MakefileSHELLreassignment for that dispatch.bash.exeexplicitly (via its standard Git-for-Windows install path) instead of relying onbashresolving on PATH, since machines with WSL installed can havebashresolve to the WSL launcher stub ahead of Git Bash.make up/make build/make seed), the first thing OSS adopters run — fixing it before the Aug 18 launch.Closes #253
Test plan
make buildfrom Windows PowerShell now completes withBUILD SUCCESSacross all 8 Maven modulesgit difflimited toMakefile)bashvia theelsebranch — same commands as before)