fix: split publish-central into per-module deploys - #265
Merged
Conversation
A combined 'mvn deploy -pl core,sdk-kotlin' lets central-publishing-maven-plugin (extensions=true) share one central-staging dir across both reactor projects, and only the last project's bundle actually gets uploaded as its own Central component. idem-sdk-kotlin:0.1.0 was built, signed, and staged in the v0.1.0 release but never published as a result. Splitting into two independent single-module deploys gives each its own staging dir, bundle, and deployment.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finance.idem:idem-sdk-kotlin:0.1.0never landed on Maven Central despite the v0.1.0 release'spublish-centraljob reporting success. Verified againstrepo1.maven.org:idem-corelatest is0.1.0,idem-sdk-kotlinlatest is still0.0.12-test.mvn deploy -pl core,sdk-kotlin. Both modules independently carrycentral-publishing-maven-plugin(extensions=true), which rebinds the deploy phase. In that combined reactor,idem-sdk-kotlin's signed artifacts get staged intoidem-core'starget/central-stagingdir, and only one bundle actually gets uploaded/published as a Central component —idem-core's.idem-sdk-kotlinwas built, signed, and staged but never became its own deployment.mvn deployinvocations (-pl core, then-pl sdk-kotlin), so each gets its own isolated staging dir, bundle, and deployment.Test plan
idem-coreandidem-sdk-kotlinat the same version, verified viarepo1.maven.org/maven2/finance/idem/{idem-core,idem-sdk-kotlin}/maven-metadata.xml.idem-sdk-kotlin:0.1.0is backfilled separately via a one-off manual deploy (not blocked on this PR).