Add multi-GPU device routing - #1
Draft
Dillflix wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IDEOGRAM4_DIFFUSION_DEVICEandIDEOGRAM4_TEXT_DEVICEenvironment-variable routing without changing the ComfyUI node interface or existing workflowsIdeogram4Pipeline.from_pretrainedMotivation
The wrapper currently constructs and caches a monolithic pipeline on
cuda. This prevents users with multiple GPUs from placing the one-time Qwen3-VL text encoder separately from the repeatedly executed diffusion transformers and VAE.When the new variables are unset, both roles still resolve to
cuda, preserving existing behavior and workflow compatibility.Core dependency
This wrapper change depends on ideogram-oss/ideogram4#38, which adds the backward-compatible
text_devicepipeline argument and compact pre-denoise feature transfer.Validation
nodes.pyand the new testHardware validation status
The available development host has CPU-only PyTorch, so the target ROCm configuration has not been run here. The README documents editable installation of the modified core, runtime device-name preflight, explicit indexed devices, the expected ComfyUI launch command, and the direct-transfer/CPU-staging behavior.