Skip to content

FEAT: New Behaviour Finger Counter using MediaPipe's HandLandMarker Hand Detection Model. - #12

Open
diogoalvessoares wants to merge 7 commits into
developfrom
feat/behaviour-finger-counter
Open

diogoalvessoares wants to merge 7 commits into
developfrom
feat/behaviour-finger-counter

Conversation

@diogoalvessoares

@diogoalvessoares diogoalvessoares commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Notes

  • New features
  • Bug fixes
  • Documentation
  • Maintenance
  • Tests
  • Design

Old behaviour

New behaviour

  • behaviour_finger_counter: detects the number of fingers being held up (1 to 5) and prints the result to the terminal in real time. Uses MediaPipe HandLandmarker for accurate finger joint detection. REQUIRES: Python 3.11 or 3.12, mediapipe installed;
  • hand_landmarker: mediaPipe's hand detection model.

@diogoalvessoares
diogoalvessoares requested a review from a team May 8, 2026 16:12
@LVGoncalves LVGoncalves changed the title FEATURE: New Behaviour Finger Counter. FEAT: New Behaviour Finger Counter. May 8, 2026
@LVGoncalves

Copy link
Copy Markdown
Collaborator

For pull requests like this, nothing needs to be added to the "Old behaviour"

@diogoalvessoares diogoalvessoares changed the title FEAT: New Behaviour Finger Counter. FEAT: New Behaviour Finger Counter using MediaPipe's HandLandMarker Hand Detection Model. May 9, 2026
@diogoalvessoares

diogoalvessoares commented May 9, 2026

Copy link
Copy Markdown
Collaborator Author

Hello Lucas.
Thank you for the advice. The same was made with another pull request (branch: feat/behaviour-ouch).
Do you mean by not adding anything bellow the Old Behaviour section title? Or not having that section at all?
Either way, its not critical.
Have added more stuff to this pull request so please review the changes.

  • added missing hand_landmarker.task which is the hand detection model, updated on the pull request description;
  • updated the name of the pull request.

Hope you like it!
Regards,
Diogo.

@LVGoncalves

Copy link
Copy Markdown
Collaborator

Hello Lucas. Thank you for the advice. The same was made with another pull request (branch: feat/behaviour-ouch). Do you mean by not adding anything bellow the Old Behaviour section title? Or not having that section at all?

You can keep the Old Behaviour since is part of a template.

* added missing hand_landmarker.task which is the hand detection model, updated on the pull request description;

Ideally, since it is a tool only for one behaviour, ideally you would add a note on the install code to install that model instead of adding it to the repo, to allow for faster clones and fetches. It would be even better if there was just some bash commands to install that.

@LVGoncalves

Copy link
Copy Markdown
Collaborator

Please add this behaviour to start.sh and to the iddle mode inside mode manager. Everything related to this behaviour should be done from this pull request. Please, leave it commented inside start.sh for now.

@diogoalvessoares

Copy link
Copy Markdown
Collaborator Author

Hello.

The scripts are updated on a different branch called "mnt/scripts", with the pull request title of "MNT: Update start and webapp scripts & New script for Kiosk Settings.".

Please check on that and let me know what you think there.

Regards,

Diogo.

… variable, edit behaviour's class to match file name, edit behaviour's main function to match file name and switch prints to logs for behaviour history register.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants