Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c86db193a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
README.md
Outdated
|
|
||
| ```bash | ||
| # Load .env and run (Arbitrum One - will skip, already deployed) | ||
| forge script script/DeployIDOSNodeStaking.s.sol --rpc-url arbitrumOne --broadcast |
There was a problem hiding this comment.
The migration documents forge script ... --rpc-url arbitrumOne|sepolia here, but this commit does not add a foundry.toml with [rpc_endpoints] aliases (repo-wide search shows no foundry.toml), so the documented deploy flow cannot run as written after moving off Hardhat network config. In practice, users will hit an invalid/unknown RPC URL unless they manually replace these aliases with full URLs, which breaks the primary deployment instructions.
Useful? React with 👍 / 👎.
pkoch
force-pushed
the
feat/migrate-to-foundry
branch
from
373ec3d to
c9c21fe
Compare
1 participant
In order to make it easier to do an integrated test of CCADisbursementTracker.sol with CCA later on.