Skip to content

fix(avatar): restore beta portraits and preview poses - #307

Merged
ifBars merged 1 commit into
betafrom
agent/beta-047-avatar-rendering
Sep 20, 2026
Merged

ifBars merged 1 commit into
betafrom
agent/beta-047-avatar-rendering

Conversation

@ifBars

@ifBars ifBars commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Schedule I 0.4.7 replaced the avatar pipeline, leaving beta.1's NPC portraits, accessory icons, and NPC workbench preview unavailable. This restores them using the native appearance/outfit model and a detached rendering rig with an explicit portrait camera.

The rig resets look targets, animation state, inherited attachments, distance impostors, and cached mesh shape values. This fixes tilted heads, stale clothing, overlapping impostors, and clothing clipping. Native appearance import and current player/creator appearance getters use the beta data model. Scene cleanup releases the shared rig and cancels stale capture work.

Includes the 3.2.1-beta.2 version bump, GitHub prerelease notes, and updated appearance/workbench docs. Related to #305.

Validation

  • Full solution builds: MonoMelon and Il2CppMelon, zero warnings/errors, against 0.4.7f5 beta assemblies (Mono build 25407174; IL2CPP build 25404402).
  • Contract suites: Mono 723 passed; IL2CPP 709 passed. Ran dotnet test S1API.Tests/S1API.Tests.csproj -c <configuration> --no-build --no-restore after each matching build.
  • Live checks in each runtime: initial save load and exit-to-menu/reload; Ludwig mugshot; requested red cap through the accessory helper; native NPC import and detached preview. Inspected images for pose, appearance, framing, duplicate geometry, and missing accessories. The probe also asserts visible red-cap pixels, not just nonblank output.
  • Separate visual checks in both runtimes: standing, sitting, crouching, and Reset returning to the front-facing standing view.
  • Smoke runs are capped at 40 seconds, with earlier failure callbacks. Probe sources, logs, and game-derived images remain local and excluded from Git.
  • DocFX HTML build passed with zero warnings/errors. Full local PDF export was stopped after exceeding the iteration budget; the required hosted documentation job remains the complete publication gate.

Compatibility

  • No public/protected signatures, parameter names, durable IDs, or save/network formats changed.
  • Existing builder/resource-path inputs, explicit NPC icon precedence, and retaining the previous icon after capture failure remain supported.
  • Accessory icons still prefer the local player's basic appearance and use the neutral fallback before player availability.
  • Restored beta appearance getters/imports can expose native avatar-object IDs; the appearance adapter accepts those IDs as well as legacy resource paths.
  • This prerelease publishes only to GitHub, following VERSIONING.md.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: c4da386a-077c-437c-8295-dbea08afb717

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ifBars
ifBars merged commit 9d9d077 into beta Sep 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant