No pandas#489
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the pandas dependency from the Python condensation-substepping test/utility scripts by switching CSV IO and comparisons to the standard library (csv), and refreshes the stored reference CSV accordingly.
Changes:
- Replace
pandasDataFrame CSV writing inlgrngn_cond_substepping.pywith acsv.DictWriter-based helper. - Replace
pandas/numpy-based CSV loading/merge/compare logic inlgrngn_cond_substepping_test.pywith pure-stdlib row matching and tolerance checks. - Replace
pandas-based plotting input inlgrngn_cond_substepping_plot.pywithcsv.DictReaderparsing; update the reference CSV dataset.
Reviewed changes
Copilot reviewed 3 out of 12 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/python/physics/refdata/lgrngn_cond_substepping_refdata.csv |
Updated reference dataset to match the new CSV writing/serialization and current outputs. |
tests/python/physics/lgrngn_cond_substepping.py |
Drops pandas and adds _write_csv() to persist records via csv.DictWriter. |
tests/python/physics/lgrngn_cond_substepping_test.py |
Drops pandas/numpy and reimplements CSV comparison by config-key mapping and manual tolerance checks. |
tests/python/physics/lgrngn_cond_substepping_plot.py |
Drops pandas and reimplements grouping/plot data extraction from CSV rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.