Skip to content

No pandas#489

Merged
pdziekan merged 4 commits into
igfuw:masterfrom
pdziekan:no_pandas
May 14, 2026
Merged

No pandas#489
pdziekan merged 4 commits into
igfuw:masterfrom
pdziekan:no_pandas

Conversation

@pdziekan
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 14, 2026 12:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the pandas dependency from the Python condensation-substepping test/utility scripts by switching CSV IO and comparisons to the standard library (csv), and refreshes the stored reference CSV accordingly.

Changes:

  • Replace pandas DataFrame CSV writing in lgrngn_cond_substepping.py with a csv.DictWriter-based helper.
  • Replace pandas/numpy-based CSV loading/merge/compare logic in lgrngn_cond_substepping_test.py with pure-stdlib row matching and tolerance checks.
  • Replace pandas-based plotting input in lgrngn_cond_substepping_plot.py with csv.DictReader parsing; update the reference CSV dataset.

Reviewed changes

Copilot reviewed 3 out of 12 changed files in this pull request and generated 3 comments.

File Description
tests/python/physics/refdata/lgrngn_cond_substepping_refdata.csv Updated reference dataset to match the new CSV writing/serialization and current outputs.
tests/python/physics/lgrngn_cond_substepping.py Drops pandas and adds _write_csv() to persist records via csv.DictWriter.
tests/python/physics/lgrngn_cond_substepping_test.py Drops pandas/numpy and reimplements CSV comparison by config-key mapping and manual tolerance checks.
tests/python/physics/lgrngn_cond_substepping_plot.py Drops pandas and reimplements grouping/plot data extraction from CSV rows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/python/physics/lgrngn_cond_substepping_test.py Outdated
Comment thread tests/python/physics/lgrngn_cond_substepping_test.py Outdated
Comment thread tests/python/physics/lgrngn_cond_substepping.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@pdziekan pdziekan merged commit 3334310 into igfuw:master May 14, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants