Ice - new test and minor changes#88
Merged
Merged
Conversation
Contributor
AgnieszkaMakulska
commented
Apr 9, 2026
- adding a test comparing results of lagrangian and bulk ice microphysics
- spectrum of ice_a and ice_c can be diagnosed
- rd_insol included in the "aerosol" dict
There was a problem hiding this comment.
Pull request overview
This PR extends the parcel-model ice workflow by (1) adding/adjusting long tests that compare Lagrangian vs bulk ice results and generate diagnostic plots, and (2) evolving the aerosol configuration to include rd_insol inside the aerosol JSON spec (plus a new depo toggle for depositional growth).
Changes:
- Require
rd_insolinside each aerosol mode definition (update defaults + tests accordingly). - Add
depooption and wire it into the Lagrangian microphysics step. - Add/adjust long tests and plotting outputs for warm/ice scheme comparisons; extend spectrum diagnostics to support
drwt = ice_a/ice_c.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| unit_test/test_RH.py | Updates aerosol JSON in RH test to include rd_insol. |
| unit_test/test_moments.py | Updates aerosol JSON fixture to include rd_insol. |
| unit_test/test_init.py | Updates parametrized aerosol cases to include rd_insol. |
| unit_test/test_chem_henry.py | Updates aerosol JSON in chemistry Henry-law test to include rd_insol. |
| parcel.py | Adds depo kwarg; updates default aerosol JSON to include rd_insol; updates docstring. |
| parcel_common.py | Enforces presence of rd_insol in aerosol dict validation. |
| micro_lgrngn.py | Uses aerosol-provided rd_insol in distribution key; forwards depo to libcloudphxx options. |
| io_output.py | Adds support for diagnosing ice_a/ice_c spectra; tweaks bin metadata description. |
| functions.py | Adds helper converting RH w.r.t liquid to RH w.r.t ice. |
| chem_conditions.py | Adds rd_insol into chemistry example aerosol JSON. |
| long_test/test_timestep.py | Updates aerosol JSON to include rd_insol. |
| long_test/test_plot_schemes_warm.py | Uses common.rho_w and renames output plot file to warm-specific name. |
| long_test/test_compare_schemes_warm.py | Uses common.rho_w for condensed-water conversion. |
| long_test/test_bulk_ice.py | Updates docstring to reflect current bulk-ice invocation. |
| long_test/test_plot_schemes_ice.py | New long test for ice-scheme comparison plot generation. |
| long_test/test_plot_ice_SD.py | Improves plot styling/labels; switches plot outputs to SVG; passes rd_insol via aerosol JSON; enables depo. |
| long_test/test_ice_SD.py | Enables depo; moves rd_insol into aerosol JSON; removes rd_insol kwarg usage. |
| plots/outputs/plot_schemes_ice.svg | Adds checked-in generated SVG artifact for ice-scheme comparison plot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pdziekan
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.