Repository navigation
[BUG] Keep the harness compiling on CI runners - #22
Merged
Merged
Conversation
The camera/microphone device checks (#21) grew the harness's single async validation function past what the macOS CI runner can compile: the Swift frontend was killed (signal 9) and main's native-client check is red. Move three self-contained sections out of `run` without changing them: media/display/window-management requests, prompts/file choosers, and the new device checks (HarnessMediaDeviceValidation.swift). A clean local build's peak frontend memory drops from 26.6 GB to 15.9 GB, and build time from 156 s to 52 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #21,
native-clientCI fails onmain. The Swift frontend is killed (signal 9) while compilingChromiumHarnessValidation.swift. Itsrunfunction is one ~1,900-line async body. With the run body stubbed, the file needs 0.8 GB; with it, 26.6 GB. The device checks #21 added there pushed it over the runner's limit. (#19 passed at 19 minutes, already at the edge.)Fix
Pure code motion; no check changes. Three self-contained sections leave
run:validateMediaPermissions: camera/microphone, display capture and window management.validatePrompts: JavaScript dialogs, before-unload, HTTP auth, file choosers and exclusive access.HarnessMediaDeviceValidation.swift: the [BUG] Let sites list and pick cameras and microphones after Allow #21 device checks.checksis passedinout, so partial results still reach failure reports. An indentation-insensitive comparison shows only the moved statements and new wrappers changed.Validation
93c1dad)swift-frontendmemory, clean debug buildpython3 -m unittest,node Tests/test_smoke_fixture.mjs,swift test(34) andswift build --product CobbleChromiumClientpass. The native harness was not rerun: a foreground-only DevTools check needs the Mac's focus, which a pending macOS dialog holds. The moved code is unchanged, and the native payload is unaffected.🤖 Generated with Claude Code