Skip to content

[BUG] Open Chromium link tabs in the right engine and undo tab closes - #28

Merged
ignaciojuarez merged 1 commit into
mainfrom
t3/0d22d7f1
Nov 10, 2026
Merged

ignaciojuarez merged 1 commit into
mainfrom
t3/0d22d7f1

Conversation

@ignaciojuarez

Copy link
Copy Markdown
Owner

What changes

  • Link tabs from Chromium tabs (⌘-click, middle-click, Open Link in New Tab) now use Automatic engine selection, like WebKit tabs have since [BUG] Ensure auto engine selection for new tabs opened via links #21.
  • New setting: Settings › Web Engine › Links opened in new tabs, either Automatic (the default) or Current Tab (keeps the opener tab's engine). It is saved on this Mac only.
  • ⌘Z on Chromium pages now reopens the last closed tab. Before, Chromium's view took undo:, so the window's Undo Close Tab never ran. If a text field is focused and you typed in it after the close, ⌘Z goes to the page instead.

Tests

  • ./Scripts/test.sh: 650 tests, 2 skipped, 0 failures
  • swift test --filter ChromiumAdapterTests: passing

Not verified

  • Not run by hand in a Full build. The Chromium link-tab routing reads the child's URL after the SDK delivers its state. If that URL isn't ready, the tab falls back to the old behavior and stays in Chromium.

🤖 Generated with Claude Code

- Links opened in new tabs from Chromium tabs (⌘-click, middle-click, Open
  Link in New Tab) now use Automatic engine selection, like WebKit tabs.
- New Settings › Web Engine › Links opened in new tabs: Automatic or
  Current Tab.
- ⌘Z reopens a closed tab while a Chromium page is focused, unless you
  typed in one of its text fields after closing the tab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ignaciojuarez
ignaciojuarez merged commit 6c02199 into main Nov 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant